2010 November, 19 (Guerric)
Table of contents
Editor Plugin Diff
Overall, it looks like you've done a good job containing the editor in a plugin. I'ld like to make more changes to how the editor is actually loaded(new/different PHP hooks) but we can make those changes after making the changes outlined below.
Question:
Where does the editor hook on to the "Edit Page" button?
Remove FCKEditor
Remove all code that deals with FCKEditor. We will not ship that editor with Pipestone. We will only support CKEditor.
Rename plugins
editor => page_editor
ckeditor => page_editor_ckeditor
nav.js
File a bug for this file. We should not have a direct dependency on the editor. We really need a global unload handler. Don't worry about fixing this, just file a TODO bug.
skins/common/popups/plugins/wysiwyg.js
What is this file used for?
Can it be moved into the plugin folder?
skins/common/wikibits.js
Can you move the section editing hooks into a javascript file for the editor?
I would like to move the js files closer to where they are used. Since this is specific functionality for the editor, it should be moved into the editor plugin.
skins/common/javascript.php
Move everything editor related into the editor plugin. You can hook onto MAIN_PROCESS_OUTPUT or another hook to append additional javascript to the document head.
plugins/editor/config.php
Instead of creating a separate file for this, use an ajax formatter in the editor.php file. Create another formatter within the plugin for retrieving the editor configuration.
Let me know if you need help with this. Since it's not the expected JSON content type, you'll have to hook onto the INIT_FORMATTER hook as well.
plugins/ckeditor/editor.js
you have a typo
Deki.Plugin.CKEditor.prototype.IsSupproted = function()
should be prototype.IsSupported
- Tag page
- What links here
| Images 0 | ||
|---|---|---|
| No images to display in the gallery. |
Copyright © 2011 MindTouch, Inc. Powered by